Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugin version to v3.4.0 in deployment examples #419

Merged

Conversation

almaslennikov
Copy link
Contributor

@almaslennikov almaslennikov commented Mar 29, 2022

Proposal for the future:
Using a specific version of the plugin in deployment examples requires updating it for each release. This poses a risk of users
deploying an older version of the plugin than the specific one they checked out.

The proposal is to always use latest and then in every release, update yaml for the release and upload it to the release page.

@adrianchiris
Copy link
Contributor

Hi @almaslennikov, i think its fine to bump the .yaml to last release like we did before (i.e bump to v3.4.0)
So we dont change customer experience to much.

we should first agree on this approach in a community meeting,

there are a couple of issues around release proceess and image tag management::

#367
#374

@almaslennikov almaslennikov changed the title Use latest plugin version in deployment examples Bump plugin version to v3.4.0 in deployment examples Mar 29, 2022
@almaslennikov
Copy link
Contributor Author

@adrianchiris Let's bump it to the v3.4.0 now and discuss the transition to latest or stable tags in the future

@e0ne
Copy link
Collaborator

e0ne commented Apr 6, 2022

@SchSeba @zshi-redhat could you please take a look on this PR once you have a time?

@zeeke
Copy link
Member

zeeke commented Apr 7, 2022

LGTM

@zshi-redhat
Copy link
Collaborator

zshi-redhat commented Apr 7, 2022

Mellanox CI failed, shall we rerun? I cannot see the details of the CI job (404 not found).

@adrianchiris
Copy link
Contributor

/retest

@adrianchiris adrianchiris merged commit 2ef2867 into k8snetworkplumbingwg:master Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants